caohoangha126 commented on PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#issuecomment-2643324196
@nastra @nk1506 Hi, sorry to bother you again. I need this fix for my work
and hope to get it in a future upgrade. Can you please reopen the PR and get it
merged? Thank you so much,
github-actions[bot] commented on PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#issuecomment-2585490558
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If y
github-actions[bot] closed pull request #9184: Core: Suppress exceptions in
case of dropTableData
URL: https://github.com/apache/iceberg/pull/9184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#issuecomment-2571448843
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
nk1506 commented on code in PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#discussion_r1871445945
##
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##
@@ -150,8 +154,7 @@ private static void deleteFiles(FileIO io,
Set allManifests) {
String
nastra commented on code in PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#discussion_r1869614642
##
core/src/test/java/org/apache/iceberg/hadoop/TestCatalogUtilDropTable.java:
##
@@ -19,6 +19,7 @@
package org.apache.iceberg.hadoop;
import static org.assertj.core
nastra commented on code in PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#discussion_r1869635184
##
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##
@@ -99,7 +98,12 @@ public static void dropTableData(FileIO io, TableMetadata
metadata) {
Set manifest
nastra commented on code in PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#discussion_r1869631423
##
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##
@@ -150,8 +154,7 @@ private static void deleteFiles(FileIO io,
Set allManifests) {
String
nastra commented on code in PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#discussion_r1869624012
##
core/src/test/java/org/apache/iceberg/hadoop/TestCatalogUtilDropTable.java:
##
@@ -56,6 +57,23 @@
public class TestCatalogUtilDropTable extends HadoopTableTestBase
nastra commented on PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#issuecomment-2514287398
@nk1506 could you rebase the PR please and apply the review comments? I'll
review it afterwards
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
github-actions[bot] commented on PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#issuecomment-2508748199
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
caohoangha126 commented on PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#issuecomment-2445697418
@nk1506 some checks failed and block merging, do you mind taking a look?
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
nk1506 opened a new pull request, #9184:
URL: https://github.com/apache/iceberg/pull/9184
With
[dropTableData](https://github.com/apache/iceberg/blob/d247b20f166ccb0b92443d4b05330b1e0d9c5d49/core/src/main/java/org/apache/iceberg/CatalogUtil.java#L86)
we plan to delete orphan files as many a
caohoangha126 commented on PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#issuecomment-2445040832
@nk1506 @Fokko Hi, this bug is impacting our work and we are hoping that we
can get the fix in a future upgrade. Is it possible to get it merged? Thanks!
--
This is an automated m
github-actions[bot] commented on PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#issuecomment-2412570820
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If y
github-actions[bot] closed pull request #9184: Core: Suppress exceptions in
case of dropTableData
URL: https://github.com/apache/iceberg/pull/9184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
caohoangha126 commented on PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#issuecomment-2260746069
Hi! Noticed that we got a fix for [this
issue](https://github.com/apache/iceberg/issues/9164) in this PR. What is
blocking this one from merging? Thanks!
--
This is an automated
nk1506 commented on PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#issuecomment-1874868435
@Fokko , A gentle reminder for the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nk1506 commented on PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#issuecomment-1862108119
@Fokko , Please let me know what do you think on my comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
nk1506 commented on code in PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#discussion_r1411662284
##
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##
@@ -91,7 +90,12 @@ public static void dropTableData(FileIO io, TableMetadata
metadata) {
Set manifest
nk1506 commented on code in PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#discussion_r1411645521
##
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##
@@ -150,8 +154,7 @@ private static void deleteFiles(FileIO io,
Set allManifests) {
String
Fokko commented on PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#issuecomment-1835463313
Thanks for picking this up @nk1506! Left two minor comments, let me know
what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Fokko commented on code in PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#discussion_r1411609064
##
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##
@@ -91,7 +90,12 @@ public static void dropTableData(FileIO io, TableMetadata
metadata) {
Set manifests
Fokko commented on code in PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#discussion_r1411608715
##
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##
@@ -150,8 +154,7 @@ private static void deleteFiles(FileIO io,
Set allManifests) {
String
nk1506 opened a new pull request, #9184:
URL: https://github.com/apache/iceberg/pull/9184
With
[dropTableData](https://github.com/apache/iceberg/blob/d247b20f166ccb0b92443d4b05330b1e0d9c5d49/core/src/main/java/org/apache/iceberg/CatalogUtil.java#L86)
we plan to delete orphan files as many a
25 matches
Mail list logo
