nastra commented on code in PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#discussion_r1869631423
##########
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##########
@@ -150,8 +154,7 @@ private static void deleteFiles(FileIO io,
Set<ManifestFile> allManifests) {
String type = reader.isDeleteManifestReader() ? "delete" :
"data";
deleteFiles(io, pathsToDelete, type, false);
} catch (IOException e) {
- throw new RuntimeIOException(
- e, "Failed to read manifest file: %s", manifest.path());
+ LOG.warn("Failed to read manifest file: {}", manifest.path(),
e);
Review Comment:
this part of the code isn't actually being tested, so please add a separate
test where this code path would be reached
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
