Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on PR #11495: URL: https://github.com/apache/iceberg/pull/11495#issuecomment-2469024997 Thanks for reviewing, @nastra @danielcweeks @jbonofre @amogh-jahagirdar! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi merged PR #11495: URL: https://github.com/apache/iceberg/pull/11495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Core: Support commits with DVs [iceberg]

danielcweeks commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1837127586 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -268,9 +274,32 @@ private void add(PendingDeleteFile file) { if (deleteFiles.ad

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1837117968 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteManifestsAction.java: ## @@ -956,6 +956,62 @@ public void testRewriteLargeDeleteMan

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1837104323 ## core/src/test/java/org/apache/iceberg/TestBase.java: ## @@ -643,6 +666,22 @@ protected DataFile newDataFile(String partitionPath) { .build(); } +

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1837092881 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -268,9 +274,32 @@ private void add(PendingDeleteFile file) { if (deleteFiles.add

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1837091098 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteManifestsAction.java: ## @@ -956,6 +956,62 @@ public void testRewriteLargeDeleteMan

Re: [PR] Core: Support commits with DVs [iceberg]

danielcweeks commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1837076611 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteManifestsAction.java: ## @@ -956,6 +956,62 @@ public void testRewriteLargeDeleteMa

Re: [PR] Core: Support commits with DVs [iceberg]

danielcweeks commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1837051720 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -268,9 +274,32 @@ private void add(PendingDeleteFile file) { if (deleteFiles.ad

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835613879 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1836738741 ## core/src/test/java/org/apache/iceberg/TestBase.java: ## @@ -643,6 +666,22 @@ protected DataFile newDataFile(String partitionPath) { .build(); } +

Re: [PR] Core: Support commits with DVs [iceberg]

nastra commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1836701207 ## core/src/test/java/org/apache/iceberg/TestBase.java: ## @@ -643,6 +666,22 @@ protected DataFile newDataFile(String partitionPath) { .build(); } + pro

Re: [PR] Core: Support commits with DVs [iceberg]

nastra commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1836698961 ## core/src/test/java/org/apache/iceberg/TestSnapshotSummary.java: ## @@ -78,7 +78,7 @@ public void testFileSizeSummary() { @TestTemplate public void testFileS

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1836685282 ## core/src/test/java/org/apache/iceberg/TestSnapshotSummary.java: ## @@ -78,7 +78,7 @@ public void testFileSizeSummary() { @TestTemplate public void test

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1836687170 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteManifestsAction.java: ## @@ -719,7 +719,7 @@ public void testRewriteLargeManifestsE

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1836685282 ## core/src/test/java/org/apache/iceberg/TestSnapshotSummary.java: ## @@ -78,7 +78,7 @@ public void testFileSizeSummary() { @TestTemplate public void test

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1836681746 ## core/src/test/java/org/apache/iceberg/TestBase.java: ## @@ -643,6 +666,22 @@ protected DataFile newDataFile(String partitionPath) { .build(); } +

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1836681746 ## core/src/test/java/org/apache/iceberg/TestBase.java: ## @@ -643,6 +666,22 @@ protected DataFile newDataFile(String partitionPath) { .build(); } +

Re: [PR] Core: Support commits with DVs [iceberg]

nastra commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1836209280 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteManifestsAction.java: ## @@ -719,7 +719,7 @@ public void testRewriteLargeManifestsEvolve

Re: [PR] Core: Support commits with DVs [iceberg]

nastra commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1836207152 ## core/src/test/java/org/apache/iceberg/TestSnapshotSummary.java: ## @@ -78,7 +78,7 @@ public void testFileSizeSummary() { @TestTemplate public void testFileS

Re: [PR] Core: Support commits with DVs [iceberg]

nastra commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1836205922 ## core/src/test/java/org/apache/iceberg/TestBase.java: ## @@ -643,6 +666,22 @@ protected DataFile newDataFile(String partitionPath) { .build(); } + pro

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835614940 ## core/src/main/java/org/apache/iceberg/BaseRowDelta.java: ## @@ -139,6 +139,10 @@ protected void validate(TableMetadata base, Snapshot parent) { if (val

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835614576 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -769,6 +794,82 @@ protected void validateDataFilesExist( } } + // validate

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835614371 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -769,6 +794,82 @@ protected void validateDataFilesExist( } } + // validate

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835613879 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835613811 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -271,6 +276,26 @@ private void add(PendingDeleteFile file) { } } + protect

Re: [PR] Core: Support commits with DVs [iceberg]

jbonofre commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835329015 ## core/src/main/java/org/apache/iceberg/BaseRowDelta.java: ## @@ -139,6 +139,10 @@ protected void validate(TableMetadata base, Snapshot parent) { if (valida

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835144928 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

Re: [PR] Core: Support commits with DVs [iceberg]

amogh-jahagirdar commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835155795 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -769,6 +794,82 @@ protected void validateDataFilesExist( } } + // val

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835152614 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835152614 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835152614 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835147603 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835144928 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835114428 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835114428 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

Re: [PR] Core: Support commits with DVs [iceberg]

danielcweeks commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835104546 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fi

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1834857507 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -769,6 +794,82 @@ protected void validateDataFilesExist( } } + // validate

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1834857507 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -769,6 +794,82 @@ protected void validateDataFilesExist( } } + // validate