aokolnychyi commented on code in PR #11495:
URL: https://github.com/apache/iceberg/pull/11495#discussion_r1837104323
##########
core/src/test/java/org/apache/iceberg/TestBase.java:
##########
@@ -643,6 +666,22 @@ protected DataFile newDataFile(String partitionPath) {
.build();
}
+ protected DeleteFile fileADeletes() {
+ return formatVersion >= 3 ? FILE_A_DV : FILE_A_DELETES;
+ }
+
+ protected DeleteFile fileBDeletes() {
+ return formatVersion >= 3 ? FILE_B_DV : FILE_B_DELETES;
+ }
+
+ protected DeleteFile newDeletes(DataFile dataFile) {
Review Comment:
I went to rename and I remembered why I did it this way. I wanted a way to
construct a V2 delete file independently of the format version and to not need
to update the other methods that create delete files now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
