kevinjqliu commented on code in PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#discussion_r1818193692
##
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##
@@ -129,13 +129,12 @@ static Snapshot fromJson(JsonNode node) {
"Cannot parse summary f
kevinjqliu commented on code in PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#discussion_r1818193692
##
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##
@@ -129,13 +129,12 @@ static Snapshot fromJson(JsonNode node) {
"Cannot parse summary f
amogh-jahagirdar commented on code in PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#discussion_r1817912195
##
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##
@@ -129,13 +129,12 @@ static Snapshot fromJson(JsonNode node) {
"Cannot parse sum
amogh-jahagirdar commented on code in PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#discussion_r1817912195
##
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##
@@ -129,13 +129,12 @@ static Snapshot fromJson(JsonNode node) {
"Cannot parse sum
amogh-jahagirdar commented on code in PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#discussion_r1817912195
##
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##
@@ -129,13 +129,12 @@ static Snapshot fromJson(JsonNode node) {
"Cannot parse sum
amogh-jahagirdar commented on code in PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#discussion_r1817905519
##
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##
@@ -129,13 +129,12 @@ static Snapshot fromJson(JsonNode node) {
"Cannot parse sum
amogh-jahagirdar commented on code in PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#discussion_r1817905519
##
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##
@@ -129,13 +129,12 @@ static Snapshot fromJson(JsonNode node) {
"Cannot parse sum
rdblue commented on code in PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#discussion_r1817898860
##
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##
@@ -129,13 +129,12 @@ static Snapshot fromJson(JsonNode node) {
"Cannot parse summary from
amogh-jahagirdar merged PR #11354:
URL: https://github.com/apache/iceberg/pull/11354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
kevinjqliu commented on code in PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#discussion_r1817229656
##
core/src/test/java/org/apache/iceberg/TestSnapshotJson.java:
##
@@ -74,21 +72,23 @@ public void testToJsonWithOperation() throws IOException {
Immu
amogh-jahagirdar commented on PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#issuecomment-2438901117
Thanks @kevinjqliu , I caught up on the discussion and this looks right to
me! thanks @nastra , @RussellSpitzer for the reviews.
--
This is an automated message from the Apac
kevinjqliu commented on PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#issuecomment-2438753142
> Yes I meant checking there is no top level "operation" field
{
snapshot {
operation: {} // <-- Did we do this before?
summary: {}
}
@RussellSpitzer I don't thin
RussellSpitzer commented on PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#issuecomment-2438745450
> @RussellSpitzer On write, the `operation` field is added to the `summary`
map
https://github.com/apache/iceberg/pull/11354/files#diff-7ed51a90c01ae74858022052b57c6b39544e1fa5f4
kevinjqliu commented on PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#issuecomment-2438725062
@RussellSpitzer On write, the `operation` field is added to the `summary`
map
https://github.com/apache/iceberg/pull/11354/files#diff-7ed51a90c01ae74858022052b57c6b39544e1fa5f4bf
14 matches
Mail list logo
