kevinjqliu commented on code in PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#discussion_r1817229656


##########
core/src/test/java/org/apache/iceberg/TestSnapshotJson.java:
##########
@@ -74,21 +72,23 @@ public void testToJsonWithOperation() throws IOException {
             ImmutableMap.of("files-added", "4", "files-deleted", "100"),
             3,
             manifestList);
+    Map<String, String> expectedSummary =
+        ImmutableMap.<String, String>builder()
+            .putAll(expected.summary())
+            .put("operation", expected.operation()) // operation is part of 
the summary
+            .build();
 
     String json = SnapshotParser.toJson(expected);
-
-    // Assert that the JSON contains the expected summary
     ObjectMapper objectMapper = new ObjectMapper();
     JsonNode jsonNode = objectMapper.readTree(json);
+
+    // Assert that the summary node exists
+    assertThat(jsonNode.get("summary")).isNotNull();
+
+    // Assert that the JSON contains the expected summary

Review Comment:
   removed!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to