Re: [PR] Core: Prevent duplicate data/delete files [iceberg]

nastra commented on code in PR #10007: URL: https://github.com/apache/iceberg/pull/10007#discussion_r1587260164 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -83,9 +85,13 @@ protected Map summary() { @Override public FastAppend appendFile(DataFile file)

Re: [PR] Core: Prevent duplicate data/delete files [iceberg]

Fokko commented on code in PR #10007: URL: https://github.com/apache/iceberg/pull/10007#discussion_r1582803332 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -83,9 +85,13 @@ protected Map summary() { @Override public FastAppend appendFile(DataFile file)

Re: [PR] Core: Prevent duplicate data/delete files [iceberg]

fqaiser94 commented on code in PR #10007: URL: https://github.com/apache/iceberg/pull/10007#discussion_r1578482898 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -243,9 +247,12 @@ private void add(DeleteFileHolder fileHolder) { PartitionSpec fi

Re: [PR] Core: Prevent duplicate data/delete files [iceberg]

danielcweeks commented on code in PR #10007: URL: https://github.com/apache/iceberg/pull/10007#discussion_r1534831074 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -43,6 +44,7 @@ class FastAppend extends SnapshotProducer implements AppendFiles { private fin

Re: [PR] Core: Prevent duplicate data/delete files [iceberg]

danielcweeks commented on code in PR #10007: URL: https://github.com/apache/iceberg/pull/10007#discussion_r1534110571 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -43,6 +44,7 @@ class FastAppend extends SnapshotProducer implements AppendFiles { private fin