danielcweeks commented on code in PR #10007:
URL: https://github.com/apache/iceberg/pull/10007#discussion_r1534110571
##########
core/src/main/java/org/apache/iceberg/FastAppend.java:
##########
@@ -43,6 +44,7 @@ class FastAppend extends SnapshotProducer<AppendFiles>
implements AppendFiles {
private final PartitionSpec spec;
private final SnapshotSummary.Builder summaryBuilder =
SnapshotSummary.builder();
private final List<DataFile> newFiles = Lists.newArrayList();
+ private final CharSequenceSet newFilePaths = CharSequenceSet.empty();
Review Comment:
I feel like it might make this cleaner to just implement equal and hash code
then use a `LinkedHashSet` instead of the list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
