Re: [PR] Core: Pass storage credentials from LoadTableResponse to FileIO [iceberg]

2025-04-22 Thread via GitHub
tedyu commented on code in PR #12591: URL: https://github.com/apache/iceberg/pull/12591#discussion_r2054133147 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -547,4 +563,28 @@ private boolean recoverObject(ObjectVersion version, String bucket) { retu

Re: [PR] Core: Pass storage credentials from LoadTableResponse to FileIO [iceberg]

2025-04-22 Thread via GitHub
tedyu commented on code in PR #12591: URL: https://github.com/apache/iceberg/pull/12591#discussion_r2053684180 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -547,4 +563,28 @@ private boolean recoverObject(ObjectVersion version, String bucket) { retu

Re: [PR] Core: Pass storage credentials from LoadTableResponse to FileIO [iceberg]

2025-04-22 Thread via GitHub
tedyu commented on code in PR #12591: URL: https://github.com/apache/iceberg/pull/12591#discussion_r2053684180 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -547,4 +563,28 @@ private boolean recoverObject(ObjectVersion version, String bucket) { retu

Re: [PR] Core: Pass storage credentials from LoadTableResponse to FileIO [iceberg]

2025-04-21 Thread via GitHub
nastra commented on code in PR #12591: URL: https://github.com/apache/iceberg/pull/12591#discussion_r2053420927 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -547,4 +563,28 @@ private boolean recoverObject(ObjectVersion version, String bucket) { ret

Re: [PR] Core: Pass storage credentials from LoadTableResponse to FileIO [iceberg]

2025-04-18 Thread via GitHub
tedyu commented on code in PR #12591: URL: https://github.com/apache/iceberg/pull/12591#discussion_r2050867855 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -547,4 +563,28 @@ private boolean recoverObject(ObjectVersion version, String bucket) { retu

Re: [PR] Core: Pass storage credentials from LoadTableResponse to FileIO [iceberg]

2025-04-05 Thread via GitHub
danielcweeks commented on code in PR #12591: URL: https://github.com/apache/iceberg/pull/12591#discussion_r2021685856 ## core/src/main/java/org/apache/iceberg/rest/responses/LoadTableResponse.java: ## @@ -80,7 +81,24 @@ public TableMetadata tableMetadata() { } public Map

Re: [PR] Core: Pass storage credentials from LoadTableResponse to FileIO [iceberg]

2025-04-02 Thread via GitHub
nastra commented on PR #12591: URL: https://github.com/apache/iceberg/pull/12591#issuecomment-2771433944 thanks for the reviews @amogh-jahagirdar and @danielcweeks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Core: Pass storage credentials from LoadTableResponse to FileIO [iceberg]

2025-04-02 Thread via GitHub
nastra merged PR #12591: URL: https://github.com/apache/iceberg/pull/12591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Core: Pass storage credentials from LoadTableResponse to FileIO [iceberg]

2025-04-01 Thread via GitHub
nastra commented on code in PR #12591: URL: https://github.com/apache/iceberg/pull/12591#discussion_r2024132740 ## core/src/main/java/org/apache/iceberg/io/SupportsStorageCredentials.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Core: Pass storage credentials from LoadTableResponse to FileIO [iceberg]

2025-04-01 Thread via GitHub
amogh-jahagirdar commented on code in PR #12591: URL: https://github.com/apache/iceberg/pull/12591#discussion_r2023775261 ## core/src/main/java/org/apache/iceberg/io/SupportsStorageCredentials.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und