tedyu commented on code in PR #12591:
URL: https://github.com/apache/iceberg/pull/12591#discussion_r2050867855
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -547,4 +563,28 @@ private boolean recoverObject(ObjectVersion version,
String bucket) {
return true;
}
+
+ @Override
+ public void setCredentials(List<StorageCredential> credentials) {
Review Comment:
From what I observe, the `this.storageCredentials` can be wrapped in
`ImmutableList.copyOf`. This way, `credentials()` doesn't have to create a copy
every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
