tedyu commented on code in PR #12591:
URL: https://github.com/apache/iceberg/pull/12591#discussion_r2054133147
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -547,4 +563,28 @@ private boolean recoverObject(ObjectVersion version,
String bucket) {
return true;
}
+
+ @Override
+ public void setCredentials(List<StorageCredential> credentials) {
Review Comment:
I think the getter can be written this way (with additional field called
`copy`):
first time getter assigns ImmutableList.copyOf() to `copy` field
subsequently `copy` field is returned directly until setter is called
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
