KarldBai commented on PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#issuecomment-2556378835
New to iceberg forgive me if this is dumb. I noticed that in 1.4.x there was
a canContainPosDeletesForFile() method that checkes whether data file path id
falls into delete file's upper-
aokolnychyi merged PR #9251:
URL: https://github.com/apache/iceberg/pull/9251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
aokolnychyi commented on PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#issuecomment-1861462818
I run the benchmark one more time and did not see any difference with the
precondition, so I'll keep it for clarity. I also played around with the
on-demand indexing but the current s
szehon-ho commented on code in PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#discussion_r1429779656
##
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##
@@ -582,93 +513,187 @@ private
Iterable>> deleteManifestRea
}
}
- // a group of indexed
aokolnychyi commented on code in PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#discussion_r1427628834
##
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##
@@ -582,93 +513,187 @@ private
Iterable>> deleteManifestRea
}
}
- // a group of indexe
aokolnychyi commented on code in PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#discussion_r1427628834
##
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##
@@ -582,93 +513,187 @@ private
Iterable>> deleteManifestRea
}
}
- // a group of indexe
aokolnychyi commented on code in PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#discussion_r1427621708
##
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##
@@ -582,93 +513,187 @@ private
Iterable>> deleteManifestRea
}
}
- // a group of indexe
aokolnychyi commented on code in PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#discussion_r1427619933
##
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##
@@ -582,93 +513,187 @@ private
Iterable>> deleteManifestRea
}
}
- // a group of indexe
aokolnychyi commented on code in PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#discussion_r1427617315
##
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##
@@ -474,68 +420,64 @@ private Collection loadDeleteFiles() {
DeleteFileIndex build() {
szehon-ho commented on code in PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#discussion_r1427495126
##
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##
@@ -582,93 +513,187 @@ private
Iterable>> deleteManifestRea
}
}
- // a group of indexed
szehon-ho commented on code in PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#discussion_r1427495126
##
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##
@@ -582,93 +513,187 @@ private
Iterable>> deleteManifestRea
}
}
- // a group of indexed
aokolnychyi commented on code in PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#discussion_r1427120373
##
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##
@@ -582,93 +513,187 @@ private
Iterable>> deleteManifestRea
}
}
- // a group of indexe
aokolnychyi commented on code in PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#discussion_r1427120373
##
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##
@@ -582,93 +513,187 @@ private
Iterable>> deleteManifestRea
}
}
- // a group of indexe
szehon-ho commented on code in PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#discussion_r1426773779
##
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##
@@ -582,93 +513,187 @@ private
Iterable>> deleteManifestRea
}
}
- // a group of indexed
szehon-ho commented on code in PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#discussion_r1426773779
##
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##
@@ -582,93 +513,187 @@ private
Iterable>> deleteManifestRea
}
}
- // a group of indexed
aokolnychyi commented on code in PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#discussion_r1425370701
##
core/src/main/java/org/apache/iceberg/util/ArrayUtil.java:
##
@@ -320,4 +320,29 @@ public static boolean isStrictlyAscending(long[] array) {
return true;
aokolnychyi commented on code in PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#discussion_r1426529884
##
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##
@@ -474,68 +420,64 @@ private Collection loadDeleteFiles() {
DeleteFileIndex build() {
aokolnychyi commented on code in PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#discussion_r1426529884
##
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##
@@ -474,68 +420,64 @@ private Collection loadDeleteFiles() {
DeleteFileIndex build() {
aokolnychyi commented on PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#issuecomment-1855575637
@szehon-ho, could you take another look? I did some updates and added a
benchmark. The performance is OK for now but we can definitely optimize it
further in following PRs.
--
This
19 matches
Mail list logo
