KarldBai commented on PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#issuecomment-2556378835

   New to iceberg forgive me if this is dumb. I noticed that in 1.4.x there was 
a canContainPosDeletesForFile() method that checkes whether data file path id 
falls into delete file's upper-lower range. Is this part removed in 1.5.x?
   My scenario is flink cdc upsert mode. Every batch of data is in deletion 
vector format: all rows of data, all rows of eq-delete file with only pk 
columns, a pos delete file for those self-redundant rows in this batch. 
   So with the old logic, validateNoNewDeletesForDataFiles() will always be 
good, but with the new one, all the new pos delete files will trigger exception 
and fail the commit. 
   Am I getting all these right? If so could you tell me why we have this new 
logic in 1.5.x? Thank you!  
   @aokolnychyi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to