aokolnychyi commented on code in PR #9251:
URL: https://github.com/apache/iceberg/pull/9251#discussion_r1425370701
##########
core/src/main/java/org/apache/iceberg/util/ArrayUtil.java:
##########
@@ -320,4 +320,29 @@ public static boolean isStrictlyAscending(long[] array) {
return true;
}
+
+ @SuppressWarnings("unchecked")
+ public static <T> T[] concat(Class<T> type, T[]... arrays) {
Review Comment:
I should probably add Javadoc on handling null arrays here.
##########
core/src/main/java/org/apache/iceberg/util/ArrayUtil.java:
##########
@@ -320,4 +320,29 @@ public static boolean isStrictlyAscending(long[] array) {
return true;
}
+
+ @SuppressWarnings("unchecked")
+ public static <T> T[] concat(Class<T> type, T[]... arrays) {
Review Comment:
We are trying to avoid an explicit dependency on commons. Guava has a method
to merge two but it does not support an array of arrays .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
