Re: [PR] Core: Derive 'operation' from view version [iceberg]

2023-10-20 Thread via GitHub
rdblue merged PR #8678: URL: https://github.com/apache/iceberg/pull/8678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Core: Derive 'operation' from view version [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on PR #8678: URL: https://github.com/apache/iceberg/pull/8678#issuecomment-1773497347 Thanks, @nastra! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Core: Derive 'operation' from view version [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #8678: URL: https://github.com/apache/iceberg/pull/8678#discussion_r1367544626 ## core/src/test/java/org/apache/iceberg/view/TestViewMetadataParser.java: ## @@ -335,7 +335,7 @@ public void metadataCompression(String fileName) throws IOException {

Re: [PR] Core: Derive 'operation' from view version [iceberg]

2023-10-13 Thread via GitHub
nastra commented on code in PR #8678: URL: https://github.com/apache/iceberg/pull/8678#discussion_r1357855073 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -99,7 +100,7 @@ public void basicCreateView() { .timestampMillis(view.current

Re: [PR] Core: Derive 'operation' from view version [iceberg]

2023-10-13 Thread via GitHub
nastra commented on code in PR #8678: URL: https://github.com/apache/iceberg/pull/8678#discussion_r1357853053 ## core/src/main/java/org/apache/iceberg/view/BaseMetastoreViewCatalog.java: ## @@ -161,7 +162,7 @@ private View create(ViewOperations ops) { .defaultName