Re: [PR] Core: Assign fresh IDs to view schema [iceberg]

nastra closed pull request #10253: Core: Assign fresh IDs to view schema URL: https://github.com/apache/iceberg/pull/10253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] Core: Assign fresh IDs to view schema [iceberg]

nastra opened a new pull request, #10253: URL: https://github.com/apache/iceberg/pull/10253 This addresses https://github.com/apache/iceberg/pull/9596#discussion_r1473187177 and assigns fresh IDs to a View's schema when creating/replacing a view -- This is an automated message from the A

Re: [PR] Core: Assign fresh IDs to view schema [iceberg]

nastra commented on code in PR #10253: URL: https://github.com/apache/iceberg/pull/10253#discussion_r1877460844 ## core/src/main/java/org/apache/iceberg/view/ViewUtil.java: ## @@ -18,12 +18,34 @@ */ package org.apache.iceberg.view; +import java.util.List; +import java.util.

Re: [PR] Core: Assign fresh IDs to view schema [iceberg]

rdblue commented on code in PR #10253: URL: https://github.com/apache/iceberg/pull/10253#discussion_r1876380842 ## core/src/main/java/org/apache/iceberg/view/ViewUtil.java: ## @@ -18,12 +18,34 @@ */ package org.apache.iceberg.view; +import java.util.List; +import java.util.

Re: [PR] Core: Assign fresh IDs to view schema [iceberg]

rdblue commented on code in PR #10253: URL: https://github.com/apache/iceberg/pull/10253#discussion_r1876428234 ## core/src/test/java/org/apache/iceberg/view/TestViewUtil.java: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core: Assign fresh IDs to view schema [iceberg]

rdblue commented on code in PR #10253: URL: https://github.com/apache/iceberg/pull/10253#discussion_r1876425086 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -1341,6 +1343,8 @@ public View create() { Preconditions.checkState( null

Re: [PR] Core: Assign fresh IDs to view schema [iceberg]

rdblue commented on code in PR #10253: URL: https://github.com/apache/iceberg/pull/10253#discussion_r1876379535 ## core/src/main/java/org/apache/iceberg/view/ViewUtil.java: ## @@ -18,12 +18,34 @@ */ package org.apache.iceberg.view; +import java.util.List; +import java.util.

Re: [PR] Core: Assign fresh IDs to view schema [iceberg]

nastra commented on code in PR #10253: URL: https://github.com/apache/iceberg/pull/10253#discussion_r1875960542 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1798,8 +1798,9 @@ public void createOrReplaceViewKeepsViewHisto

Re: [PR] Core: Assign fresh IDs to view schema [iceberg]

amogh-jahagirdar commented on code in PR #10253: URL: https://github.com/apache/iceberg/pull/10253#discussion_r1875107084 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1798,8 +1798,9 @@ public void createOrReplaceViewKeep

Re: [PR] Core: Assign fresh IDs to view schema [iceberg]

github-actions[bot] commented on PR #10253: URL: https://github.com/apache/iceberg/pull/10253#issuecomment-2452745478 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Core: Assign fresh IDs to view schema [iceberg]

nastra commented on code in PR #10253: URL: https://github.com/apache/iceberg/pull/10253#discussion_r1584840748 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -52,8 +52,27 @@ public abstract class ViewCatalogTests