amogh-jahagirdar commented on code in PR #10253:
URL: https://github.com/apache/iceberg/pull/10253#discussion_r1875107084
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -1798,8 +1798,9 @@ public void createOrReplaceViewKeepsViewHistory() {
assertThat(view.schema().asStruct())
.isEqualTo(
new Schema(
- Types.NestedField.optional(0, "new_id",
Types.IntegerType.get(), "some ID"),
- Types.NestedField.optional(1, "new_data",
Types.StringType.get(), "some data"))
+ 0,
+ Types.NestedField.optional(1, "new_id",
Types.IntegerType.get(), "some ID"),
+ Types.NestedField.optional(2, "new_data",
Types.StringType.get(), "some data"))
Review Comment:
So the first field ID changed to 1 because `highestFieldId` is set to 0 and
then incremented when assigning the new IDs? This should be fine and aligns
with whatever we do for tables. It also does not impact existing views because
we're assigning the fresh IDs from a higher field ID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
