nastra commented on code in PR #10253:
URL: https://github.com/apache/iceberg/pull/10253#discussion_r1584840748
##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -52,8 +52,27 @@ public abstract class ViewCatalogTests<C extends ViewCatalog
& SupportsNamespace
required(3, "id", Types.IntegerType.get(), "unique ID"),
required(4, "data", Types.StringType.get()));
+ // actual schema for the view, with column IDs reassigned
+ protected static final Schema VIEW_SCHEMA =
+ new Schema(
+ 0,
+ required(1, "id", Types.IntegerType.get(), "unique ID"),
+ required(2, "data", Types.StringType.get()));
+
private static final Schema OTHER_SCHEMA =
- new Schema(7, required(1, "some_id", Types.IntegerType.get()));
+ new Schema(
Review Comment:
changing this to show that the new column get's a re-assigned column ID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
