Re: [PR] Core: Add validation for table commit properties [iceberg]

szehon-ho commented on PR #11437: URL: https://github.com/apache/iceberg/pull/11437#issuecomment-2452749792 Merged, thanks @dramaticlly ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Core: Add validation for table commit properties [iceberg]

szehon-ho merged PR #11437: URL: https://github.com/apache/iceberg/pull/11437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Core: Add validation for table commit properties [iceberg]

szehon-ho commented on code in PR #11437: URL: https://github.com/apache/iceberg/pull/11437#discussion_r1826273849 ## core/src/main/java/org/apache/iceberg/util/PropertyUtil.java: ## @@ -57,6 +67,19 @@ public static double propertyAsDouble( return defaultValue; } + pu

Re: [PR] Core: Add validation for table commit properties [iceberg]

dramaticlly commented on code in PR #11437: URL: https://github.com/apache/iceberg/pull/11437#discussion_r1826214271 ## core/src/main/java/org/apache/iceberg/util/PropertyUtil.java: ## @@ -57,6 +67,19 @@ public static double propertyAsDouble( return defaultValue; } +

Re: [PR] Core: Add validation for table commit properties [iceberg]

szehon-ho commented on code in PR #11437: URL: https://github.com/apache/iceberg/pull/11437#discussion_r1826111628 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -486,6 +489,10 @@ public int propertyAsInt(String property, int defaultValue) { return Prop

Re: [PR] Core: Add validation for table commit properties [iceberg]

szehon-ho commented on code in PR #11437: URL: https://github.com/apache/iceberg/pull/11437#discussion_r1826110743 ## core/src/main/java/org/apache/iceberg/util/PropertyUtil.java: ## @@ -100,6 +123,28 @@ public static String propertyAsString( return defaultValue; } +

Re: [PR] Core: Add validation for table commit properties [iceberg]

dramaticlly commented on code in PR #11437: URL: https://github.com/apache/iceberg/pull/11437#discussion_r1825258756 ## core/src/main/java/org/apache/iceberg/util/PropertyUtil.java: ## @@ -100,6 +102,30 @@ public static String propertyAsString( return defaultValue; } +

Re: [PR] Core: Add validation for table commit properties [iceberg]

dramaticlly commented on code in PR #11437: URL: https://github.com/apache/iceberg/pull/11437#discussion_r1825260078 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -486,6 +489,10 @@ public int propertyAsInt(String property, int defaultValue) { return Pr

Re: [PR] Core: Add validation for table commit properties [iceberg]

dramaticlly commented on code in PR #11437: URL: https://github.com/apache/iceberg/pull/11437#discussion_r1825257015 ## core/src/main/java/org/apache/iceberg/util/PropertyUtil.java: ## @@ -100,6 +102,30 @@ public static String propertyAsString( return defaultValue; } +

Re: [PR] Core: Add validation for table commit properties [iceberg]

dramaticlly commented on code in PR #11437: URL: https://github.com/apache/iceberg/pull/11437#discussion_r1825256804 ## core/src/main/java/org/apache/iceberg/TableProperties.java: ## @@ -95,6 +95,13 @@ private TableProperties() {} public static final String COMMIT_TOTAL_RETRY

Re: [PR] Core: Add validation for table commit properties [iceberg]

szehon-ho commented on code in PR #11437: URL: https://github.com/apache/iceberg/pull/11437#discussion_r1824969871 ## core/src/main/java/org/apache/iceberg/util/PropertyUtil.java: ## @@ -100,6 +102,30 @@ public static String propertyAsString( return defaultValue; } +

[PR] Core: Add validation for table commit properties [iceberg]

dramaticlly opened a new pull request, #11437: URL: https://github.com/apache/iceberg/pull/11437 close #11435 Total of 2 Changes proposed here 1. Add validation for creating new table where commit related table properties need to have value type checked (as integer) and value