dramaticlly opened a new pull request, #11437:
URL: https://github.com/apache/iceberg/pull/11437
close #11435
Total of 2 Changes proposed here
1. Add validation for creating new table where commit related table
properties need to have value type checked (as integer) and value is
non-negative. This apply to following 4 table properties as those are common
set of properties to be used on commit for metadata changes
1. commit.retry.num-retries
1. commit.retry.min-wait-ms
1. commit.retry.max-wait-ms
1. commit.retry.total-timeout-ms
1. Relax the constrain of
[PendingUpdate](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/PropertiesUpdate.java#L100-L114)
so that existing table with such corrupted table properties can proceed with
correction (see example below)
- achieved by using
[NumberUtils::toInt](https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/math/NumberUtils.html#toInt(java.lang.String,int))
where return the default value if the conversion fails.
This allow for
```java
// some mistake at first
table
.updateProperties()
.set(TableProperties.COMMIT_MAX_RETRY_WAIT_MS, "foo")
.commit();
// fail before, pass after
table.updateProperties().remove(TableProperties.COMMIT_MAX_RETRY_WAIT_MS).commit();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
