dramaticlly commented on code in PR #11437:
URL: https://github.com/apache/iceberg/pull/11437#discussion_r1825258756
##########
core/src/main/java/org/apache/iceberg/util/PropertyUtil.java:
##########
@@ -100,6 +102,30 @@ public static String propertyAsString(
return defaultValue;
}
+ /**
+ * Validate the table commit related properties to have non-negative integer
on table creation to
+ * prevent commit failure
+ *
+ * @param properties input map
+ */
+ public static void validateCommitProperties(Map<String, String> properties) {
+ for (String commitProperty : TableProperties.COMMIT_PROPERTIES) {
Review Comment:
Actually with exception handling and validation throwing new exceptions in
the code, I think for each loop shall be fine. Let me know if you hate it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
