Re: [PR] Core: Add tests for catalogs supporting empty namespaces [iceberg]

2025-01-13 Thread via GitHub
Fokko merged PR #9890: URL: https://github.com/apache/iceberg/pull/9890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] Core: Add tests for catalogs supporting empty namespaces [iceberg]

2024-10-21 Thread via GitHub
github-actions[bot] commented on PR #9890: URL: https://github.com/apache/iceberg/pull/9890#issuecomment-2427964242 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Core: Add tests for catalogs supporting empty namespaces [iceberg]

2024-03-28 Thread via GitHub
RussellSpitzer commented on code in PR #9890: URL: https://github.com/apache/iceberg/pull/9890#discussion_r1543108275 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1429,40 +1429,28 @@ public void showViews() throws NoSuch

Re: [PR] Core: Add tests for catalogs supporting empty namespaces [iceberg]

2024-03-28 Thread via GitHub
RussellSpitzer commented on code in PR #9890: URL: https://github.com/apache/iceberg/pull/9890#discussion_r1543102376 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcUtil.java: ## @@ -45,4 +47,10 @@ public void testFilterAndRemovePrefix() { assertThat(expected).isEq

Re: [PR] Core: Add tests for catalogs supporting empty namespaces [iceberg]

2024-03-28 Thread via GitHub
RussellSpitzer commented on code in PR #9890: URL: https://github.com/apache/iceberg/pull/9890#discussion_r1543101785 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1428,40 +1428,28 @@ public void showViews() throws NoSuch

Re: [PR] Core: Add tests for catalogs supporting empty namespaces [iceberg]

2024-03-28 Thread via GitHub
nastra commented on code in PR #9890: URL: https://github.com/apache/iceberg/pull/9890#discussion_r1543085683 ## core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java: ## @@ -288,6 +288,7 @@ public List listNamespaces(Namespace namespace) throws NoSuchNamespac

Re: [PR] Core: Add tests for catalogs supporting empty namespaces [iceberg]

2024-03-28 Thread via GitHub
RussellSpitzer commented on code in PR #9890: URL: https://github.com/apache/iceberg/pull/9890#discussion_r1543073405 ## core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java: ## @@ -288,6 +288,7 @@ public List listNamespaces(Namespace namespace) throws NoSuchName

Re: [PR] Core: Add tests for catalogs supporting empty namespaces [iceberg]

2024-03-28 Thread via GitHub
RussellSpitzer commented on code in PR #9890: URL: https://github.com/apache/iceberg/pull/9890#discussion_r1543070548 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java: ## @@ -468,6 +468,10 @@ private JdbcUtil() {} static Namespace stringToNamespace(String namespa

Re: [PR] Core: Add tests for catalogs supporting empty namespaces [iceberg]

2024-03-28 Thread via GitHub
RussellSpitzer commented on code in PR #9890: URL: https://github.com/apache/iceberg/pull/9890#discussion_r1543069444 ## core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java: ## @@ -288,6 +288,7 @@ public List listNamespaces(Namespace namespace) throws NoSuchName

Re: [PR] Core: Add tests for catalogs supporting empty namespaces [iceberg]

2024-03-18 Thread via GitHub
dimas-b commented on code in PR #9890: URL: https://github.com/apache/iceberg/pull/9890#discussion_r1528789710 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieCatalog.java: ## @@ -169,4 +171,25 @@ public void testWarehouseLocationWithTrailingSlash() {