nastra commented on code in PR #9890:
URL: https://github.com/apache/iceberg/pull/9890#discussion_r1543085683


##########
core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java:
##########
@@ -288,6 +288,7 @@ public List<Namespace> listNamespaces(Namespace namespace) 
throws NoSuchNamespac
 
     List<Namespace> filteredNamespaces =
         namespaces.keySet().stream()
+            .filter(n -> !n.isEmpty())

Review Comment:
   yes, `InMemoryCatalog` supports empty namespaces and this comes back to the 
TODO I added in 
https://github.com/apache/iceberg/pull/9890/files#diff-de393039ffcf049ebb22892ac1b9aad88d53274c1e86431b45e776e4568246f8R1037
 to determine what the listing behavior with empty namespaces should be



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to