RussellSpitzer commented on code in PR #9890:
URL: https://github.com/apache/iceberg/pull/9890#discussion_r1543101785
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -1428,40 +1428,28 @@ public void showViews() throws NoSuchTableException {
// spark stores temp views case-insensitive by default
Object[] tempView = row("", "tempviewforlisting", true);
- assertThat(sql("SHOW VIEWS"))
- .contains(
- row(NAMESPACE.toString(), "prefixV2", false),
- row(NAMESPACE.toString(), "prefixV3", false),
- row(NAMESPACE.toString(), "v1", false),
- tempView);
+ Object[] v1 = row(NAMESPACE.toString(), "v1", false);
+ Object[] v2 = row(NAMESPACE.toString(), "prefixV2", false);
+ Object[] v3 = row(NAMESPACE.toString(), "prefixV3", false);
+ assertThat(sql("SHOW VIEWS")).contains(v2, v3, v1, tempView);
Review Comment:
nit: (ocd) It tares me up that you define v1, v2, v3 and then check contains
v2, v3, v1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
