rdblue closed pull request #9278: Core, API: Move SQLViewRepresentation to API
URL: https://github.com/apache/iceberg/pull/9278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rdblue commented on PR #9278:
URL: https://github.com/apache/iceberg/pull/9278#issuecomment-1856181463
Closing in favor of #9302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
nastra commented on code in PR #9278:
URL: https://github.com/apache/iceberg/pull/9278#discussion_r1426921944
##
.palantir/revapi.yml:
##
@@ -877,6 +877,10 @@ acceptedBreaks:
- code: "java.field.serialVersionUIDChanged"
new: "field org.apache.iceberg.util.Serializabl
nastra commented on code in PR #9278:
URL: https://github.com/apache/iceberg/pull/9278#discussion_r1425146761
##
.palantir/revapi.yml:
##
@@ -877,6 +877,10 @@ acceptedBreaks:
- code: "java.field.serialVersionUIDChanged"
new: "field org.apache.iceberg.util.Serializabl
amogh-jahagirdar commented on code in PR #9278:
URL: https://github.com/apache/iceberg/pull/9278#discussion_r1424740521
##
.palantir/revapi.yml:
##
@@ -877,6 +877,10 @@ acceptedBreaks:
- code: "java.field.serialVersionUIDChanged"
new: "field org.apache.iceberg.util.S
amogh-jahagirdar commented on code in PR #9278:
URL: https://github.com/apache/iceberg/pull/9278#discussion_r1424739300
##
core/src/main/java/org/apache/iceberg/view/ImmutableSQLViewRepresentation.java:
##
@@ -0,0 +1,241 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
nastra commented on code in PR #9278:
URL: https://github.com/apache/iceberg/pull/9278#discussion_r1423554194
##
.palantir/revapi.yml:
##
@@ -877,6 +877,10 @@ acceptedBreaks:
- code: "java.field.serialVersionUIDChanged"
new: "field org.apache.iceberg.util.Serializabl
amogh-jahagirdar commented on code in PR #9278:
URL: https://github.com/apache/iceberg/pull/9278#discussion_r1423222132
##
.palantir/revapi.yml:
##
@@ -877,6 +877,10 @@ acceptedBreaks:
- code: "java.field.serialVersionUIDChanged"
new: "field org.apache.iceberg.util.S
amogh-jahagirdar commented on PR #9278:
URL: https://github.com/apache/iceberg/pull/9278#issuecomment-1851053058
Ah I see the flink failure was fixed recently in
https://github.com/apache/iceberg/pull/9216, I just need to rebase
--
This is an automated message from the Apache Git Service.
amogh-jahagirdar commented on PR #9278:
URL: https://github.com/apache/iceberg/pull/9278#issuecomment-1851051133
Looks like some unrelated Flink tests failed, noting here:
```
TestIcebergSourceWithWatermarkExtractor > testThrottling FAILED
java.lang.AssertionError:
amogh-jahagirdar closed pull request #9278: Core, API: Move
SQLViewRepresentation to API
URL: https://github.com/apache/iceberg/pull/9278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
amogh-jahagirdar commented on code in PR #9278:
URL: https://github.com/apache/iceberg/pull/9278#discussion_r1423222132
##
.palantir/revapi.yml:
##
@@ -877,6 +877,10 @@ acceptedBreaks:
- code: "java.field.serialVersionUIDChanged"
new: "field org.apache.iceberg.util.S
amogh-jahagirdar commented on code in PR #9278:
URL: https://github.com/apache/iceberg/pull/9278#discussion_r1423222132
##
.palantir/revapi.yml:
##
@@ -877,6 +877,10 @@ acceptedBreaks:
- code: "java.field.serialVersionUIDChanged"
new: "field org.apache.iceberg.util.S
amogh-jahagirdar commented on code in PR #9278:
URL: https://github.com/apache/iceberg/pull/9278#discussion_r1423218929
##
core/src/main/java/org/apache/iceberg/view/BaseSQLViewRepresentation.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
amogh-jahagirdar opened a new pull request, #9278:
URL: https://github.com/apache/iceberg/pull/9278
This change is similar to the one done a while back for `BaseViewVersion`.
SQLViewRepresentation is moved from the core module to the API module (since it
is a concept that's apparent in the
15 matches
Mail list logo
