amogh-jahagirdar commented on code in PR #9278:
URL: https://github.com/apache/iceberg/pull/9278#discussion_r1423222132
##########
.palantir/revapi.yml:
##########
@@ -877,6 +877,10 @@ acceptedBreaks:
- code: "java.field.serialVersionUIDChanged"
new: "field org.apache.iceberg.util.SerializableMap<K,
V>.serialVersionUID"
justification: "Serialization is not be used"
+ - code: "java.method.visibilityReduced"
+ old: "method org.apache.iceberg.view.ImmutableSQLViewRepresentation
org.apache.iceberg.view.ImmutableSQLViewRepresentation::copyOf(org.apache.iceberg.view.SQLViewRepresentation)"
+ new: "method org.apache.iceberg.view.ImmutableSQLViewRepresentation
org.apache.iceberg.view.ImmutableSQLViewRepresentation::copyOf(org.apache.iceberg.view.BaseSQLViewRepresentation)"
+ justification: "Immutables generated copyOf visibility changed"
Review Comment:
I think there must have been some behavior change in Immutables between the
original code generation for SQLViewRepresentation and now. Immutables now
generates a package-private copyOf (confirmed with ViewVersion). However, prior
to this change the generated copyOf for SQLViewRepresentation was actually
public. This is technically breaking to downgrade the copyOf but I don't see
any options in the `Immutables` doc to control this behavior. Before merging
this though, I'll explore a few options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
