amogh-jahagirdar commented on code in PR #9278:
URL: https://github.com/apache/iceberg/pull/9278#discussion_r1424740521
##########
.palantir/revapi.yml:
##########
@@ -877,6 +877,10 @@ acceptedBreaks:
- code: "java.field.serialVersionUIDChanged"
new: "field org.apache.iceberg.util.SerializableMap<K,
V>.serialVersionUID"
justification: "Serialization is not be used"
+ - code: "java.method.visibilityReduced"
+ old: "method org.apache.iceberg.view.ImmutableSQLViewRepresentation
org.apache.iceberg.view.ImmutableSQLViewRepresentation::copyOf(org.apache.iceberg.view.SQLViewRepresentation)"
+ new: "method org.apache.iceberg.view.ImmutableSQLViewRepresentation
org.apache.iceberg.view.ImmutableSQLViewRepresentation::copyOf(org.apache.iceberg.view.BaseSQLViewRepresentation)"
+ justification: "Immutables generated copyOf visibility changed"
Review Comment:
You're right, it's tied to the visibility of the actual class which makes
sense. Since we probably want to just go for 100% backwards compatibility I
went with maintaining a copy of the Immutables generated class. I explored the
option of generating a package private immutable class which we extend but
Inheritance of the class isn't possible since it's final (Immutables only
generates final classes as far as I can tell)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
