Re: [PR] Clear updates/requirements after commit [iceberg-python]

2025-05-05 Thread via GitHub
kevinjqliu commented on code in PR #1961: URL: https://github.com/apache/iceberg-python/pull/1961#discussion_r2073891892 ## pyiceberg/table/__init__.py: ## @@ -774,13 +772,15 @@ def commit_transaction(self) -> Table: updates=self._updates, requi

Re: [PR] Clear updates/requirements after commit [iceberg-python]

2025-05-03 Thread via GitHub
Fokko commented on code in PR #1961: URL: https://github.com/apache/iceberg-python/pull/1961#discussion_r2072439211 ## pyiceberg/table/__init__.py: ## @@ -774,13 +774,15 @@ def commit_transaction(self) -> Table: updates=self._updates, requiremen

Re: [PR] Clear updates/requirements after commit [iceberg-python]

2025-05-03 Thread via GitHub
Fokko commented on code in PR #1961: URL: https://github.com/apache/iceberg-python/pull/1961#discussion_r2072439106 ## pyiceberg/table/__init__.py: ## @@ -774,13 +774,15 @@ def commit_transaction(self) -> Table: updates=self._updates, requiremen

Re: [PR] Clear updates/requirements after commit [iceberg-python]

2025-05-02 Thread via GitHub
smaheshwar-pltr commented on code in PR #1961: URL: https://github.com/apache/iceberg-python/pull/1961#discussion_r2071901642 ## pyiceberg/table/__init__.py: ## @@ -774,13 +774,15 @@ def commit_transaction(self) -> Table: updates=self._updates,

Re: [PR] Clear updates/requirements after commit [iceberg-python]

2025-05-02 Thread via GitHub
smaheshwar-pltr commented on code in PR #1961: URL: https://github.com/apache/iceberg-python/pull/1961#discussion_r2071898437 ## pyiceberg/table/__init__.py: ## @@ -774,13 +774,15 @@ def commit_transaction(self) -> Table: updates=self._updates,

[PR] Clear updates/requirements after commit [iceberg-python]

2025-05-02 Thread via GitHub
Fokko opened a new pull request, #1961: URL: https://github.com/apache/iceberg-python/pull/1961 # Rationale for this change Resolves #1946 # Are these changes tested? Yes, using a test that used to fail before :) # Are there any user-facing changes? -