smaheshwar-pltr commented on code in PR #1961:
URL: https://github.com/apache/iceberg-python/pull/1961#discussion_r2071898437
##########
pyiceberg/table/__init__.py:
##########
@@ -774,13 +774,15 @@ def commit_transaction(self) -> Table:
updates=self._updates,
requirements=self._requirements,
)
+ self._updates = ()
+ self._requirements = ()
Review Comment:
Nice!
I think this code within `_apply` is now redundant: (because we do this in
`commit_transaction` now)
https://github.com/apache/iceberg-python/blob/34c89494c39916b9b1aa7e6da2c24c34c4d7f058/pyiceberg/table/__init__.py#L294-L295
@Fokko, happy to remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
