kevinjqliu commented on code in PR #1961:
URL: https://github.com/apache/iceberg-python/pull/1961#discussion_r2073891892
##########
pyiceberg/table/__init__.py:
##########
@@ -774,13 +772,15 @@ def commit_transaction(self) -> Table:
updates=self._updates,
requirements=self._requirements,
)
- return self._table
- else:
- return self._table
+
Review Comment:
`CreateTableTransaction` overrides `commit_transaction` in L821. Do we need
to do the same over there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
