manuzhang commented on PR #1395:
URL: https://github.com/apache/iceberg-python/pull/1395#issuecomment-2544562617
@kevinjqliu I think it would be better to squash commits and merge for such
PR next time.
--
This is an automated message from the Apache Git Service.
To respond to the message
kevinjqliu commented on PR #1395:
URL: https://github.com/apache/iceberg-python/pull/1395#issuecomment-2521091216
thanks for the contribution! @manuzhang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
kevinjqliu merged PR #1395:
URL: https://github.com/apache/iceberg-python/pull/1395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
manuzhang commented on PR #1395:
URL: https://github.com/apache/iceberg-python/pull/1395#issuecomment-2518942456
@kevinjqliu Fixed, thanks for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kevinjqliu commented on PR #1395:
URL: https://github.com/apache/iceberg-python/pull/1395#issuecomment-2518263595
@manuzhang looks like theres some linter issues, can you run `make lint`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kevinjqliu commented on code in PR #1395:
URL: https://github.com/apache/iceberg-python/pull/1395#discussion_r1868729404
##
.github/workflows/python-ci.yml:
##
@@ -24,6 +24,19 @@ on:
branches:
- 'main'
pull_request:
+paths:
+- '**'
+- '!.github/ISSUE_TEM
manuzhang commented on code in PR #1395:
URL: https://github.com/apache/iceberg-python/pull/1395#discussion_r1868671842
##
.github/workflows/python-ci-docs.yml:
##
@@ -24,7 +24,19 @@ on:
branches:
- 'main'
pull_request:
-
+paths:
+- '**'
+- '!.github/I
kevinjqliu commented on code in PR #1395:
URL: https://github.com/apache/iceberg-python/pull/1395#discussion_r1868521541
##
.github/workflows/python-ci.yml:
##
@@ -24,6 +24,24 @@ on:
branches:
- 'main'
pull_request:
+paths-ignore:
+- '.github/ISSUE_TEMPLATE/
manuzhang opened a new pull request, #1395:
URL: https://github.com/apache/iceberg-python/pull/1395
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
