kevinjqliu commented on code in PR #1395:
URL: https://github.com/apache/iceberg-python/pull/1395#discussion_r1868729404
##########
.github/workflows/python-ci.yml:
##########
@@ -24,6 +24,19 @@ on:
branches:
- 'main'
pull_request:
+ paths:
+ - '**'
+ - '!.github/ISSUE_TEMPLATE/**'
+ - '!.github/workflows/**'
+ - '.github/workflows/python-ci.yml'
Review Comment:
nit: wydt about adding comments to explain the syntax?
```
- '**' # Include all files and
directories in the repository by default.
- '!.github/workflows/**' # Exclude all files in the
.github/workflows/ directory.
- '.github/workflows/python-ci.yml' # Explicitly include
.github/workflows/python-ci.yml, overriding the previous exclusion.
- '!.github/ISSUE_TEMPLATE/**' # Exclude files and directories
that don't impact tests or code, including templates, metadata, and
documentation.
- '!.gitignore'
- '!.asf.yml'
- '!mkdocs/**'
- '!.gitattributes'
- '!README.md'
- '!CONTRIBUTING.md'
- '!LICENSE'
- '!NOTICE'
```
##########
.github/workflows/python-integration.yml:
##########
@@ -24,6 +24,19 @@ on:
branches:
- 'main'
pull_request:
+ paths:
+ - '**'
Review Comment:
same as above, add comments to explain the syntax
##########
.github/workflows/python-ci-docs.yml:
##########
@@ -24,7 +24,19 @@ on:
branches:
- 'main'
pull_request:
-
+ paths:
+ - '**'
+ - '!.github/ISSUE_TEMPLATE/**'
+ - '!.github/workflows/*'
+ - '.github/workflows/python-ci-docs.yml'
Review Comment:
nit, this github action is super lightweight. wydt about reverting to the
original and just let everything run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
