kevinjqliu commented on code in PR #1395:
URL: https://github.com/apache/iceberg-python/pull/1395#discussion_r1868521541
##########
.github/workflows/python-ci.yml:
##########
@@ -24,6 +24,24 @@ on:
branches:
- 'main'
pull_request:
+ paths-ignore:
+ - '.github/ISSUE_TEMPLATE/**'
+ - '.github/workflows/check-md-link.yml'
+ - '.github/workflows/license_check.yml'
+ - '.github/workflows/python-ci-docs.yml'
+ - '.github/workflows/python-integration.yml'
+ - '.github/workflows/python-release.yml'
+ - '.github/workflows/python-release-docs.yml'
+ - '.github/workflows/stale.yml'
+ - '.gitignore'
+ - '.asf.yml'
+ - 'dev/**'
Review Comment:
all the other paths LGTM except `dev/**`. This is where we set up the docker
env for integration tests. Since this GitHub Action runs the integration tests,
we should not ignore when `dev/**` changes.
##########
.github/workflows/python-ci-docs.yml:
##########
@@ -24,7 +24,9 @@ on:
branches:
- 'main'
pull_request:
-
+ paths:
+ - '.github/workflows/python-ci-docs.yml'
+ - 'mkdocs/**'
Review Comment:
this action needs to run on code changes as well. See
https://github.com/apache/iceberg-python/pull/1334/files#diff-23e8153e0fd497a9212215bd2067068f3b56fa071770c7ef326db3d3d03cee9bL825
where a mistake in docstring caused `mkdoc --strict` to fail
##########
.github/workflows/python-ci.yml:
##########
@@ -24,6 +24,24 @@ on:
branches:
- 'main'
pull_request:
+ paths-ignore:
+ - '.github/ISSUE_TEMPLATE/**'
+ - '.github/workflows/check-md-link.yml'
+ - '.github/workflows/license_check.yml'
+ - '.github/workflows/python-ci-docs.yml'
+ - '.github/workflows/python-integration.yml'
+ - '.github/workflows/python-release.yml'
+ - '.github/workflows/python-release-docs.yml'
+ - '.github/workflows/stale.yml'
Review Comment:
nit: is there a way to say "ignore everything but the current file"?
if a new GitHub Action is added, we'd have to remember to edit this
##########
.github/workflows/python-integration.yml:
##########
@@ -24,6 +24,24 @@ on:
branches:
- 'main'
pull_request:
+ paths-ignore:
+ - '.github/ISSUE_TEMPLATE/**'
+ - '.github/workflows/check-md-link.yml'
+ - '.github/workflows/license_check.yml'
+ - '.github/workflows/python-ci.yml'
+ - '.github/workflows/python-ci-docs.yml'
+ - '.github/workflows/python-release.yml'
+ - '.github/workflows/python-release-docs.yml'
+ - '.github/workflows/stale.yml'
+ - '.gitignore'
+ - '.asf.yml'
+ - 'dev/**'
Review Comment:
same as above, should not ignore `dev/**`
##########
.github/workflows/check-md-link.yml:
##########
@@ -7,6 +7,9 @@ on:
branches:
- 'main'
pull_request:
+ paths:
+ - '.github/workflows/check-md-link.yml'
+ - 'mkdocs/**'
Review Comment:
should we change the `on/push/paths` above to match?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
