Re: [PR] Arrow: Infer the types when reading [iceberg-python]

Fokko merged PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

Fokko commented on code in PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r2015042363 ## tests/integration/test_reads.py: ## @@ -837,10 +837,10 @@ def test_table_scan_default_to_large_types(catalog: Catalog) -> None: expected_schema = pa.sch

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

Fokko commented on PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#issuecomment-2755822244 > should we first bump min version to Arrow 18? If you don't use date types, then everything works fine :) I'm a bit hesitant to bump it very aggressively, see https://github.

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

kevinjqliu commented on code in PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r1991888447 ## pyiceberg/io/pyarrow.py: ## @@ -1393,9 +1393,7 @@ def _task_to_record_batches( # https://github.com/apache/arrow/issues/41884 # h

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

sungwy commented on code in PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r1985968756 ## pyiceberg/io/pyarrow.py: ## @@ -1655,19 +1646,16 @@ class ArrowProjectionVisitor(SchemaWithPartnerVisitor[pa.Array, Optional[pa.Arra _file_schema: Schema

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

Fokko commented on code in PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r1985246483 ## pyiceberg/io/pyarrow.py: ## @@ -1655,19 +1646,16 @@ class ArrowProjectionVisitor(SchemaWithPartnerVisitor[pa.Array, Optional[pa.Arra _file_schema: Schema

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

sungwy commented on code in PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r1985005690 ## pyiceberg/io/pyarrow.py: ## @@ -1655,19 +1646,16 @@ class ArrowProjectionVisitor(SchemaWithPartnerVisitor[pa.Array, Optional[pa.Arra _file_schema: Schema

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

Fokko commented on code in PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r1980345139 ## pyiceberg/io/pyarrow.py: ## @@ -1655,19 +1646,16 @@ class ArrowProjectionVisitor(SchemaWithPartnerVisitor[pa.Array, Optional[pa.Arra _file_schema: Schema

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

Fokko commented on code in PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r1980331024 ## pyiceberg/io/pyarrow.py: ## @@ -1655,19 +1646,16 @@ class ArrowProjectionVisitor(SchemaWithPartnerVisitor[pa.Array, Optional[pa.Arra _file_schema: Schema

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

sungwy commented on code in PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r1979452707 ## pyiceberg/io/pyarrow.py: ## @@ -1655,19 +1646,16 @@ class ArrowProjectionVisitor(SchemaWithPartnerVisitor[pa.Array, Optional[pa.Arra _file_schema: Schema

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

Fokko commented on code in PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r1978928467 ## pyiceberg/io/pyarrow.py: ## @@ -1655,19 +1646,16 @@ class ArrowProjectionVisitor(SchemaWithPartnerVisitor[pa.Array, Optional[pa.Arra _file_schema: Schema

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

Fokko commented on code in PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r1978930763 ## pyiceberg/io/pyarrow.py: ## @@ -1573,11 +1561,16 @@ def _table_from_scan_task(task: FileScanTask) -> pa.Table: tables = [f.result() for f in complet

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

sungwy commented on code in PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r1960579776 ## pyiceberg/io/pyarrow.py: ## @@ -1655,19 +1646,16 @@ class ArrowProjectionVisitor(SchemaWithPartnerVisitor[pa.Array, Optional[pa.Arra _file_schema: Schema

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

sungwy commented on code in PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r1960579776 ## pyiceberg/io/pyarrow.py: ## @@ -1655,19 +1646,16 @@ class ArrowProjectionVisitor(SchemaWithPartnerVisitor[pa.Array, Optional[pa.Arra _file_schema: Schema

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

sungwy commented on code in PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r1960582838 ## pyiceberg/io/pyarrow.py: ## @@ -1573,11 +1561,16 @@ def _table_from_scan_task(task: FileScanTask) -> pa.Table: tables = [f.result() for f in comple

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

Fokko commented on PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#issuecomment-2665986379 @sungwy Thoughts? :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

Fokko commented on code in PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r1959939976 ## pyiceberg/io/pyarrow.py: ## @@ -1573,11 +1561,16 @@ def _table_from_scan_task(task: FileScanTask) -> pa.Table: tables = [f.result() for f in complet

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

Fokko commented on code in PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r1959855449 ## pyiceberg/table/__init__.py: ## @@ -1750,7 +1750,7 @@ def to_arrow_batch_reader(self) -> pa.RecordBatchReader: return pa.RecordBatchReader.from_batches