kevinjqliu commented on code in PR #1669:
URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r1991888447
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1393,9 +1393,7 @@ def _task_to_record_batches(
# https://github.com/apache/arrow/issues/41884
# https://github.com/apache/arrow/issues/43183
# Would be good to remove this later on
Review Comment:
should we remove this comment? seems related to the schema type inference
https://github.com/apache/iceberg-python/commit/1b9b884e56f74c7b7d1802774317ee95d799c5f2
##########
tests/integration/test_reads.py:
##########
@@ -837,10 +837,10 @@ def test_table_scan_default_to_large_types(catalog:
Catalog) -> None:
expected_schema = pa.schema(
[
- pa.field("string", pa.large_string()),
+ pa.field("string", pa.string()),
pa.field("string-to-binary", pa.large_binary()),
- pa.field("binary", pa.large_binary()),
- pa.field("list", pa.large_list(pa.large_string())),
+ pa.field("binary", pa.binary()),
+ pa.field("list", pa.list_(pa.string())),
Review Comment:
nit: to show complex type also stays the same
```suggestion
pa.field("list", pa.list_(pa.large_string())),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
