enkidulan closed pull request #810: Adding `add_files_overwrite` method
URL: https://github.com/apache/iceberg-python/pull/810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
enkidulan commented on PR #810:
URL: https://github.com/apache/iceberg-python/pull/810#issuecomment-2261396569
Thanks for getting back to me @sungwy . I agree with your point of view and
respect the decision. I started working on this feature before #569 was
introduced, and back then `add_f
sungwy commented on PR #810:
URL: https://github.com/apache/iceberg-python/pull/810#issuecomment-2261266264
Hi @enkidulan - thank you very much for putting in the time to write up this
PR. I'm very appreciative of the work and the level of interest you have in the
new API `add_files`
enkidulan commented on PR #810:
URL: https://github.com/apache/iceberg-python/pull/810#issuecomment-2250554372
@sungwy #569 was merged last week, so I've updated this PR. Can you glance
over it and say if adding `add_files_overwrite` makes sense to you?
--
This is an automated message fro
syun64 commented on code in PR #810:
URL: https://github.com/apache/iceberg-python/pull/810#discussion_r1637326766
##
pyiceberg/table/__init__.py:
##
@@ -474,6 +474,26 @@ def add_files(self, file_paths: List[str],
snapshot_properties: Dict[str, str] =
for data_file
enkidulan commented on code in PR #810:
URL: https://github.com/apache/iceberg-python/pull/810#discussion_r1635675320
##
pyiceberg/table/__init__.py:
##
@@ -474,6 +474,26 @@ def add_files(self, file_paths: List[str],
snapshot_properties: Dict[str, str] =
for data_f
enkidulan commented on code in PR #810:
URL: https://github.com/apache/iceberg-python/pull/810#discussion_r1635151718
##
pyiceberg/table/__init__.py:
##
@@ -474,6 +474,26 @@ def add_files(self, file_paths: List[str],
snapshot_properties: Dict[str, str] =
for data_f
syun64 commented on code in PR #810:
URL: https://github.com/apache/iceberg-python/pull/810#discussion_r1634878236
##
pyiceberg/table/__init__.py:
##
@@ -474,6 +474,26 @@ def add_files(self, file_paths: List[str],
snapshot_properties: Dict[str, str] =
for data_file
