sungwy commented on PR #810:
URL: https://github.com/apache/iceberg-python/pull/810#issuecomment-2261266264
Hi @enkidulan - thank you very much for putting in the time to write up this
PR. I'm very appreciative of the work and the level of interest you have in the
new API `add_files`
I gave this a bit more thought, and I think with any new Public APIs we
introduce to the repository, we carefully consider whether the value added by
adding a new API outweighs the cost of maintaining it. A new public API means
we have a new public function that we need to support for our community to
ensure that the feature remains backward compatible.
While we could argue that the feature is simple enough since it's an
extension of two already public facing APIs, I believe that that also leads to
the counterargument, that if the function is so simple and can be achieved as a
combination of existing public APIs and have no difference in the functionality
I question why we would want to create the work of maintaining a public API.
```
with self.transaction() as tx:
tx.delete(delete_filter=overwrite_filter)
tx.add_files(file_paths=file_paths,
snapshot_properties=snapshot_properties)
```
What do you think? Are you able to achieve your desired functional outcome
without the proposed API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
