enkidulan commented on PR #810: URL: https://github.com/apache/iceberg-python/pull/810#issuecomment-2261396569
Thanks for getting back to me @sungwy . I agree with your point of view and respect the decision. I started working on this feature before #569 was introduced, and back then `add_files_overwrite` made much more sense. I updated this PR after #569 was merged because it seemed like a logical extension for the provided shortcuts. There are `append` and `overwrite` methods, so it felt like having `add_files_overwrite` shortcut in addition to `add_files` method would make sense, too. I'm closing the PR and the related issue, as the features provided in #569 are sufficient for what I need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
