Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on PR #61: URL: https://github.com/apache/iceberg-python/pull/61#issuecomment-1846157302 Thanks, @Fokko! Looks great. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue merged PR #61: URL: https://github.com/apache/iceberg-python/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1419692800 ## pyiceberg/table/snapshots.py: ## @@ -65,6 +90,25 @@ def __init__(self, operation: Operation, **data: Any) -> None: super().__init__(operation=operation,

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1419477951 ## pyiceberg/table/snapshots.py: ## @@ -19,15 +19,40 @@ Any, Dict, List, +Mapping, Optional, ) from pydantic import Field, PrivateAttr, mo

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1419062626 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +168,193 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1418935983 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +168,193 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1418934519 ## pyiceberg/table/snapshots.py: ## @@ -65,6 +90,25 @@ def __init__(self, operation: Operation, **data: Any) -> None: super().__init__(operation=operation, *

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1418932283 ## pyiceberg/table/snapshots.py: ## @@ -19,15 +19,40 @@ Any, Dict, List, +Mapping, Optional, ) from pydantic import Field, PrivateAttr, mod

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1418931669 ## pyiceberg/table/snapshots.py: ## @@ -19,15 +19,40 @@ Any, Dict, List, +Mapping, Optional, ) from pydantic import Field, PrivateAttr, mod

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1418929287 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,199 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1416462272 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1416461866 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +168,193 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1416456616 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +168,193 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1416455358 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,199 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1416449698 ## pyiceberg/table/snapshots.py: ## @@ -65,6 +90,25 @@ def __init__(self, operation: Operation, **data: Any) -> None: super().__init__(operation=operation,

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1416325238 ## pyiceberg/table/snapshots.py: ## @@ -19,15 +19,40 @@ Any, Dict, List, +Mapping, Optional, ) from pydantic import Field, PrivateAttr, mo

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1416322935 ## pyiceberg/table/snapshots.py: ## @@ -19,15 +19,40 @@ Any, Dict, List, +Mapping, Optional, ) from pydantic import Field, PrivateAttr, mo

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1416322319 ## pyiceberg/table/snapshots.py: ## @@ -19,15 +19,40 @@ Any, Dict, List, +Mapping, Optional, ) from pydantic import Field, PrivateAttr, mo

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1416320627 ## pyiceberg/table/snapshots.py: ## @@ -19,15 +19,40 @@ Any, Dict, List, +Mapping, Optional, ) from pydantic import Field, PrivateAttr, mo

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1416321121 ## pyiceberg/table/snapshots.py: ## @@ -19,15 +19,40 @@ Any, Dict, List, +Mapping, Optional, ) from pydantic import Field, PrivateAttr, mo

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1383319743 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1383329498 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,199 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1383319743 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1383296718 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1383296211 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1383293089 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1383292093 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1383290717 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1383244841 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1383232094 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1383228989 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1383228406 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1382621381 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1382621288 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1382621051 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1382620882 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1382620705 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1382620743 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1382620579 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,199 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1382620579 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,199 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1382620295 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1382619653 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1382619528 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1382619372 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1382619167 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1382618622 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,202 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1372141271 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,199 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1372141271 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,199 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1372144754 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,199 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1372143737 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,199 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1372141271 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,199 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1372139436 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,199 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1372139436 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,199 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1372134598 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,199 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

HonahX commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r137662 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,199 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

Re: [PR] Add Snapshot logic and Summary generation [iceberg-python]

HonahX commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1369660433 ## pyiceberg/table/snapshots.py: ## @@ -116,3 +144,199 @@ class MetadataLogEntry(IcebergBaseModel): class SnapshotLogEntry(IcebergBaseModel): snapshot_id: int =

[PR] Add Snapshot logic and Summary generation [iceberg-python]

Fokko opened a new pull request, #61: URL: https://github.com/apache/iceberg-python/pull/61 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m