HonahX commented on code in PR #61:
URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1371111662
##########
pyiceberg/table/snapshots.py:
##########
@@ -116,3 +144,199 @@ class MetadataLogEntry(IcebergBaseModel):
class SnapshotLogEntry(IcebergBaseModel):
snapshot_id: int = Field(alias="snapshot-id")
timestamp_ms: int = Field(alias="timestamp-ms")
+
+
+class SnapshotSummaryCollector:
+ added_size: int
+ removed_size: int
+ added_files: int
+ removed_files: int
+ added_eq_delete_files: int
+ removed_eq_delete_files: int
+ added_pos_delete_files: int
+ removed_pos_delete_files: int
+ added_delete_files: int
+ removed_delete_files: int
+ added_records: int
+ deleted_records: int
+ added_pos_deletes: int
+ removed_pos_deletes: int
+ added_eq_deletes: int
+ removed_eq_deletes: int
+
Review Comment:
In Java Implementation I saw a flag named `trustSizeAndDeleteCounts`, which
is set to false when we add a `DELETES` manifest. Based on my understanding,
the purpose of this flag is to let us skip reporting size and delete counts
related metrics when we add one or more `DELETES` manifest since we do not know
the exact number of rows deleted in the manifest.
Do we want to add the flag in this PR or in the future?
ref: https://github.com/apache/iceberg/pull/1367#discussion_r500492383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
