rdblue commented on code in PR #61: URL: https://github.com/apache/iceberg-python/pull/61#discussion_r1419477951
########## pyiceberg/table/snapshots.py: ########## @@ -19,15 +19,40 @@ Any, Dict, List, + Mapping, Optional, ) from pydantic import Field, PrivateAttr, model_serializer from pyiceberg.io import FileIO -from pyiceberg.manifest import ManifestFile, read_manifest_list +from pyiceberg.manifest import DataFile, DataFileContent, ManifestFile, read_manifest_list from pyiceberg.typedef import IcebergBaseModel +ADDED_DATA_FILES = 'added-data-files' +ADDED_DELETE_FILES = 'added-delete-files' +ADDED_EQUALITY_DELETES = 'added-equality-deletes' +ADDED_FILE_SIZE = 'added-files-size' +ADDED_POSITION_DELETES = 'added-position-deletes' +ADDED_POSITION_DELETE_FILES = 'added-position-delete-files' +ADDED_RECORDS = 'added-records' +DELETED_DATA_FILES = 'deleted-data-files' +DELETED_RECORDS = 'deleted-records' +ADDED_EQUALITY_DELETE_FILES = 'added-equality-delete-files' Review Comment: Odd that this is here rather than with the other `ADDED_` properties. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org