kevinjqliu merged PR #2190:
URL: https://github.com/apache/iceberg-python/pull/2190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
james5418 commented on code in PR #2190:
URL: https://github.com/apache/iceberg-python/pull/2190#discussion_r2217988988
##
pyiceberg/io/pyarrow.py:
##
@@ -2405,7 +2407,7 @@ def data_file_statistics_from_parquet_metadata(
if field_id not in col_aggs:
kevinjqliu commented on PR #2190:
URL: https://github.com/apache/iceberg-python/pull/2190#issuecomment-3092484992
could you also run `make lint` locally?
```
ruff
format..Failed
- hook id: ruff-format
- files were m
kevinjqliu commented on code in PR #2190:
URL: https://github.com/apache/iceberg-python/pull/2190#discussion_r2217396095
##
pyiceberg/io/pyarrow.py:
##
@@ -2405,7 +2407,7 @@ def data_file_statistics_from_parquet_metadata(
if field_id not in col_aggs:
kevinjqliu commented on code in PR #2190:
URL: https://github.com/apache/iceberg-python/pull/2190#discussion_r2216960396
##
pyiceberg/io/pyarrow.py:
##
@@ -1981,11 +1981,13 @@ def visit_unknown(self, unknown_type: UnknownType) ->
str:
class StatsAggregator:
current_min: A
james5418 opened a new pull request, #2190:
URL: https://github.com/apache/iceberg-python/pull/2190
Closes #2017
# Rationale for this change
Include the column name in the error message to make it more descriptive.
# Are these changes tested?
# Are there an