kevinjqliu commented on code in PR #2190:
URL: https://github.com/apache/iceberg-python/pull/2190#discussion_r2216960396
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1981,11 +1981,13 @@ def visit_unknown(self, unknown_type: UnknownType) ->
str:
class StatsAggregator:
current_min: Any
current_max: Any
+ column_name: str
trunc_length: Optional[int]
- def __init__(self, iceberg_type: PrimitiveType, physical_type_string: str,
trunc_length: Optional[int] = None) -> None:
+ def __init__(self, iceberg_type: PrimitiveType, physical_type_string: str,
column_name: str, trunc_length: Optional[int] = None) -> None:
Review Comment:
i think this is a backwards incompatible change...
maybe we can make column_name optional and in the last position so that its
backwards compatible..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
