kevinjqliu commented on code in PR #2190:
URL: https://github.com/apache/iceberg-python/pull/2190#discussion_r2217396095
##########
pyiceberg/io/pyarrow.py:
##########
@@ -2405,7 +2407,7 @@ def data_file_statistics_from_parquet_metadata(
if field_id not in col_aggs:
col_aggs[field_id] = StatsAggregator(
- stats_col.iceberg_type, statistics.physical_type,
stats_col.mode.length
+ stats_col.iceberg_type, statistics.physical_type,
stats_col.mode.length, stats_col.column_name
Review Comment:
I see that `StatsAggregator` is only used here. WDYT of this approach?
```
try:
col_aggs[field_id] = StatsAggregator(
stats_col.iceberg_type, statistics.physical_type,
stats_col.mode.length
)
except ValueError as e:
raise ValueError(f"{e} for column '{stats_col.column_name}'") from e
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
