Fokko merged PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.
Fokko commented on PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#issuecomment-2543116729
Thanks for raising this PR @zhjwpku and thanks for the review @gaborkaszab
@pitrou and @wgtmac
> We should just use [pre-commit](https://pre-commit.com/), which is able to
do both.
pitrou commented on PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#issuecomment-2541796460
> > Make sense, I will try to find some gh actions that are fit for these
tasks, maybe after #7 merged.
>
> Sounds great, @zhjwpku ! Also some build script that people can run
locally
pitrou commented on PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#issuecomment-2541795231
> nit: should we put cmake-format.py into a sub-folder like `scripts` or
something?
It's not a script, it's a config file for the `cmake-format` utility (yes,
it's confusing and awkwa
gaborkaszab commented on PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#issuecomment-2541485775
> Make sense, I will try to find some gh actions that are fit for these
tasks, maybe after https://github.com/apache/iceberg-cpp/pull/7 merged.
Sounds great, @zhjwpku !
Also so
zhjwpku commented on PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#issuecomment-2541476566
> One general question: I see the command in the description that leverages
this change to format CMake files. It's up to the contributor to run this
manually, and I'm wondering if it makes
gaborkaszab commented on PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#issuecomment-2541459840
One general question: I see the command in the description that leverages
this change to format CMake files. It's up to the contributor to run this
manually, and I'm wondering if it mak
gaborkaszab commented on code in PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#discussion_r1881752174
##
cmake-format.py:
##
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
pitrou commented on code in PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#discussion_r1881609652
##
cmake-format.py:
##
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# di
zhjwpku commented on code in PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#discussion_r1881282329
##
cmake-format.py:
##
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# d
gaborkaszab commented on code in PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#discussion_r1879710621
##
cmake-format.py:
##
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
pitrou commented on code in PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#discussion_r1879713332
##
cmake-format.py:
##
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# di
pitrou commented on code in PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#discussion_r1879619335
##
cmake-format.py:
##
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# di
Fokko commented on code in PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#discussion_r1879041334
##
cmake-format.py:
##
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dis
gaborkaszab commented on code in PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#discussion_r1873615824
##
cmake-format.py:
##
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
zhjwpku commented on code in PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#discussion_r1873455730
##
cmake-format.py:
##
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# d
zhjwpku commented on code in PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#discussion_r1873451868
##
src/puffin/CMakeLists.txt:
##
@@ -18,11 +18,10 @@
set(ICEBERG_PUFFIN_SOURCES demo_puffin.cc)
set(ICEBERG_PUFFIN_INCLUDES "${ICEBERG_API_DIR}")
-ADD_ICEBERG_LIB(
-
wgtmac commented on code in PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#discussion_r1873421386
##
src/puffin/CMakeLists.txt:
##
@@ -18,11 +18,10 @@
set(ICEBERG_PUFFIN_SOURCES demo_puffin.cc)
set(ICEBERG_PUFFIN_INCLUDES "${ICEBERG_API_DIR}")
-ADD_ICEBERG_LIB(
-
gaborkaszab commented on code in PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#discussion_r1873198602
##
src/puffin/CMakeLists.txt:
##
@@ -18,11 +18,10 @@
set(ICEBERG_PUFFIN_SOURCES demo_puffin.cc)
set(ICEBERG_PUFFIN_INCLUDES "${ICEBERG_API_DIR}")
-ADD_ICEBERG_LIB
zhjwpku opened a new pull request, #5:
URL: https://github.com/apache/iceberg-cpp/pull/5
use the following command to apply the rules to all existing CMakeLists.txt
find . -name CMakeLists.txt | xargs cmake-format -c cmake-format.py -i
--
This is an automated message from the Apache
20 matches
Mail list logo
