gaborkaszab commented on code in PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#discussion_r1873198602
##########
src/puffin/CMakeLists.txt:
##########
@@ -18,11 +18,10 @@
set(ICEBERG_PUFFIN_SOURCES demo_puffin.cc)
set(ICEBERG_PUFFIN_INCLUDES "${ICEBERG_API_DIR}")
-ADD_ICEBERG_LIB(
- iceberg_puffin
- CMAKE_PACKAGE_NAME
- puffin
- SOURCES
- ${ICEBERG_PUFFIN_SOURCES}
- PRIVATE_INCLUDES
- ${ICEBERG_PUFFIN_INCLUDES})
+add_iceberg_lib(iceberg_puffin
Review Comment:
Might be personal preference but I find the original formatting more
readable. I don't like this much indentation. Do you think there is a way to
configure that?
##########
cmake-format.py:
##########
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# cmake-format configuration file
+
+# -----------------------------
+# Options affecting formatting.
+# -----------------------------
+with section("format"):
+ # How wide to allow formatted cmake files
+ line_width = 90
Review Comment:
I'd prefer 100 if we see any point of limiting the line width for CMake
files at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
