Re: [PR] Access delegation [iceberg-python]

2024-11-06 Thread via GitHub
Fokko merged PR #1033: URL: https://github.com/apache/iceberg-python/pull/1033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Access delegation [iceberg-python]

2024-09-24 Thread via GitHub
sungwy commented on code in PR #1033: URL: https://github.com/apache/iceberg-python/pull/1033#discussion_r1773578960 ## pyiceberg/catalog/rest.py: ## @@ -532,7 +534,7 @@ def _config_headers(self, session: Session) -> None: session.headers["Content-type"] = "application/

Re: [PR] Access delegation [iceberg-python]

2024-09-24 Thread via GitHub
guitcastro commented on code in PR #1033: URL: https://github.com/apache/iceberg-python/pull/1033#discussion_r1773534032 ## pyiceberg/catalog/rest.py: ## @@ -532,7 +534,7 @@ def _config_headers(self, session: Session) -> None: session.headers["Content-type"] = "applicat

Re: [PR] Access delegation [iceberg-python]

2024-08-20 Thread via GitHub
guitcastro commented on code in PR #1033: URL: https://github.com/apache/iceberg-python/pull/1033#discussion_r1723770469 ## pyiceberg/catalog/rest.py: ## @@ -532,7 +534,7 @@ def _config_headers(self, session: Session) -> None: session.headers["Content-type"] = "applicat

Re: [PR] Access delegation [iceberg-python]

2024-08-19 Thread via GitHub
sungwy commented on code in PR #1033: URL: https://github.com/apache/iceberg-python/pull/1033#discussion_r1722545650 ## pyiceberg/catalog/rest.py: ## @@ -532,7 +534,7 @@ def _config_headers(self, session: Session) -> None: session.headers["Content-type"] = "application/

Re: [PR] Access delegation [iceberg-python]

2024-08-16 Thread via GitHub
guitcastro commented on PR #1033: URL: https://github.com/apache/iceberg-python/pull/1033#issuecomment-2293573800 > Sorry, I missed this one No problem at all. I have renamed the property to use dash instead of `_`. -- This is an automated message from the Apache Git Service. To res

Re: [PR] Access delegation [iceberg-python]

2024-08-16 Thread via GitHub
Fokko commented on code in PR #1033: URL: https://github.com/apache/iceberg-python/pull/1033#discussion_r1719503547 ## mkdocs/docs/configuration.md: ## @@ -198,19 +198,20 @@ catalog: -| Key | Example | Description

Re: [PR] Access delegation [iceberg-python]

2024-08-14 Thread via GitHub
guitcastro commented on PR #1033: URL: https://github.com/apache/iceberg-python/pull/1033#issuecomment-2288877101 @Fokko Can you please take a look in this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Access delegation [iceberg-python]

2024-08-12 Thread via GitHub
guitcastro commented on PR #1033: URL: https://github.com/apache/iceberg-python/pull/1033#issuecomment-2284664084 @Fokko done :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Access delegation [iceberg-python]

2024-08-12 Thread via GitHub
Fokko commented on PR #1033: URL: https://github.com/apache/iceberg-python/pull/1033#issuecomment-2284256995 @guitcastro Can you rebase this one, this looks good to me 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] Access delegation [iceberg-python]

2024-08-09 Thread via GitHub
guitcastro opened a new pull request, #1033: URL: https://github.com/apache/iceberg-python/pull/1033 This PR fix the hardcoded `X-Iceberg-Access-Delegation` header, the second point of https://github.com/apache/iceberg-python/issues/1028. It's based on the #1029 , and must be merged