guitcastro commented on code in PR #1033:
URL: https://github.com/apache/iceberg-python/pull/1033#discussion_r1773534032
##########
pyiceberg/catalog/rest.py:
##########
@@ -532,7 +534,7 @@ def _config_headers(self, session: Session) -> None:
session.headers["Content-type"] = "application/json"
session.headers["X-Client-Version"] = ICEBERG_REST_SPEC_VERSION
session.headers["User-Agent"] = f"PyIceberg/{__version__}"
- session.headers["X-Iceberg-Access-Delegation"] = "vended-credentials"
+ session.headers["X-Iceberg-Access-Delegation"] =
self.properties.get(ACCESS_DELEGATION, ACCESS_DELEGATION_DEFAULT)
Review Comment:
@sungwy I tried your code, but some tests failed with:
```
assert (
catalog._session.headers.get("Content-type") ==
"application/json"
), "Expected 'Content-Type' default header not to be overwritten"
```
I guess the idea is not allow default header override. Thus I guess having a
dedicate property still the best option. What are you thoughts on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
