Fokko commented on code in PR #1033:
URL: https://github.com/apache/iceberg-python/pull/1033#discussion_r1719503547
##########
mkdocs/docs/configuration.md:
##########
@@ -198,19 +198,20 @@ catalog:
<!-- markdown-link-check-disable -->
-| Key | Example | Description
|
-| ------------------- | -------------------------------- |
--------------------------------------------------------------------------------------------------
|
-| uri | https://rest-catalog/ws | URI identifying the
REST Server |
-| ugi | t-1234:secret | Hadoop UGI for Hive
client. |
-| credential | t-1234:secret | Credential to use
for OAuth2 credential flow when initializing the catalog
|
-| token | FEW23.DFSDF.FSDF | Bearer token value
to use for `Authorization` header
|
-| scope | openid offline corpds:ds:profile | Desired scope of
the requested security token (default : catalog)
|
-| resource | rest_catalog.iceberg.com | URI for the target
resource or service
|
-| audience | rest_catalog | Logical name of
target resource or service
|
-| rest.sigv4-enabled | true | Sign requests to
the REST Server using AWS SigV4 protocol
|
-| rest.signing-region | us-east-1 | The region to use
when SigV4 signing a request
|
-| rest.signing-name | execute-api | The service signing
name to use when SigV4 signing a request |
-| oauth2-server-uri | https://auth-service/cc | Authentication URL
to use for client credentials authentication (default: uri + 'v1/oauth/tokens')
|
+| Key | Example | Description
|
+| ------------------- | -------------------------------- |
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|
+| uri | https://rest-catalog/ws | URI identifying the
REST Server
|
+| ugi | t-1234:secret | Hadoop UGI for Hive
client.
|
+| credential | t-1234:secret | Credential to use
for OAuth2 credential flow when initializing the catalog
|
+| token | FEW23.DFSDF.FSDF | Bearer token value
to use for `Authorization` header
|
+| scope | openid offline corpds:ds:profile | Desired scope of
the requested security token (default : catalog)
|
+| resource | rest_catalog.iceberg.com | URI for the target
resource or service
|
+| audience | rest_catalog | Logical name of
target resource or service
|
+| access_delegation | remote-signing | A comma-separated
list of access mechanisms to signal the server that the client supports
delegated access. It will to be sended in `X-Iceberg-Access-Delegation` header.
(default: vended-credentials) |
Review Comment:
For the rest we all use dashes, and I think that we should use that here as
well
```suggestion
| access-delegation | remote-signing | A comma-separated
list of access mechanisms to signal the server that the client supports
delegated access. It will to be sended in `X-Iceberg-Access-Delegation` header.
(default: vended-credentials) |
```
##########
pyiceberg/catalog/rest.py:
##########
@@ -98,6 +98,8 @@ class Endpoints:
rename_table: str = "tables/rename"
+ACCESS_DELEGATION = "access_delegation"
Review Comment:
```suggestion
ACCESS_DELEGATION = "access-delegation"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
