lawofcycles commented on PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#issuecomment-2210497935
Thank you for merging @Fokko !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
lawofcycles commented on PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#issuecomment-2210496283
Thanks for reviewing @amogh-jahagirdar , @aajisaka , @geruh and @rahil-c !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Fokko merged PR #10276:
URL: https://github.com/apache/iceberg/pull/10276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
Fokko commented on PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#issuecomment-2210287505
Let's get this in, thanks @lawofcycles for working on this, and
@amogh-jahagirdar and @rahil-c for the review!
--
This is an automated message from the Apache Git Service.
To respond to
rahil-c commented on code in PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#discussion_r1666192983
##
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##
@@ -221,6 +221,69 @@ public void testUpdateTable() {
assertThat(response.ta
lawofcycles commented on code in PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#discussion_r1666063693
##
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##
@@ -221,6 +221,69 @@ public void testUpdateTable() {
assertThat(respons
rahil-c commented on code in PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#discussion_r1665217122
##
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##
@@ -221,6 +221,69 @@ public void testUpdateTable() {
assertThat(response.ta
lawofcycles commented on PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#issuecomment-2156218208
Hi @amogh-jahagirdar would you review the latest change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
lawofcycles commented on code in PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#discussion_r1632024064
##
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java:
##
@@ -231,11 +255,33 @@ static void setTableInputInformation(
.col
aajisaka commented on code in PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#discussion_r1631813358
##
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java:
##
@@ -231,11 +255,33 @@ static void setTableInputInformation(
.collec
lawofcycles commented on PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#issuecomment-2146150455
Hi @geruh would you review the latest change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lawofcycles commented on code in PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#discussion_r1621143428
##
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java:
##
@@ -234,8 +258,26 @@ static void setTableInputInformation(
Optional.ofNull
aajisaka commented on code in PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#discussion_r1616950141
##
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java:
##
@@ -234,8 +258,26 @@ static void setTableInputInformation(
Optional.ofNullabl
lawofcycles commented on PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#issuecomment-2132371867
@geruh Thank you for your review!
I have pushed the changes addressing your review comments.
Could you please take another look when you have a chance?
--
This is an automat
geruh commented on code in PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#discussion_r1606278195
##
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##
@@ -501,6 +501,97 @@ public void testColumnCommentsAndParameters() {
assertTh
geruh commented on code in PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#discussion_r1606272619
##
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java:
##
@@ -234,8 +259,26 @@ static void setTableInputInformation(
Optional.ofNullable(p
lawofcycles commented on PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#issuecomment-2106471422
Hi @geruh would you review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
17 matches
Mail list logo
